Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdout and stderr methods #2482

Merged

Conversation

mhashizume
Copy link
Contributor

Previously in Beaker, you could use standalone stdout and stderr methods to access output from remote machines.

These methods were deprecated in 2013 with voxpupuli/beaker@28b2510 and dropped entirely in voxpupuli/beaker@73a31c7.

This commit removes these updates from puppet-agent tests in favor of calling stdout and stderr methods on Result objects.

@mhashizume mhashizume added the maintenance Maintenance chores are typically excluded from changelogs label Jan 31, 2024
@mhashizume mhashizume requested a review from a team as a code owner January 31, 2024 19:59
@mhashizume mhashizume force-pushed the PA-5022/main/beaker-deprecated branch 2 times, most recently from 01dd63d to cfa6c78 Compare January 31, 2024 23:27
@mhashizume mhashizume marked this pull request as draft February 1, 2024 21:07
@mhashizume mhashizume marked this pull request as ready for review February 1, 2024 23:30
@mhashizume mhashizume force-pushed the PA-5022/main/beaker-deprecated branch from cfa6c78 to 17a052c Compare February 1, 2024 23:31
Previously in Beaker, you could use standalone stdout and stderr methods
to access output from remote machines.

These methods were deprecated in 2013 with voxpupuli/beaker@28b2510 and
dropped entirely in voxpupuli/beaker@73a31c7.

This commit removes these methods from puppet-agent tests in favor of
calling stdout and stderr methods on Result objects.
@tvpartytonight tvpartytonight force-pushed the PA-5022/main/beaker-deprecated branch from 17a052c to f13f035 Compare February 5, 2024 22:00
@tvpartytonight tvpartytonight merged commit 78463e0 into puppetlabs:main Feb 5, 2024
3 checks passed
@mhashizume mhashizume added the backport 7.x Generate a backport PR to 7.x label Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Successfully created backport PR for 7.x:

@mhashizume mhashizume deleted the PA-5022/main/beaker-deprecated branch February 8, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 7.x Generate a backport PR to 7.x maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants